-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Grade Calculator (v1) #246
base: main
Are you sure you want to change the base?
Conversation
ba3ca0e
to
1f566f2
Compare
1f566f2
to
2f2a70a
Compare
Please extensively test the calculator's math! |
To do: displaying rules in the grade calc |
CanvasPlusPlayground/Features/Grades/GradeCalculator/GradeCalculator.swift
Outdated
Show resolved
Hide resolved
Screen.Recording.2025-03-02.at.4.45.22.PM.movDouble clicking doesn't seem to allow editing, only single clicking works. My institution to edit is to double click not single click, but that may just be me |
Screen.Recording.2025-03-02.at.4.49.19.PM.movUpdating the percentage for the first time causes a glitch, the cursor should be before the %? There's no glitch if I edit it again. 1%2 is treated as 1% |
Screen.Recording.2025-03-02.at.4.51.37.PM.movadding more than 2 digits for the weight percentage causes the same glitch as above |
I agree, but this is SwiftUI's default behavior :/ |
This is a SwiftUI glitch when using the |
@rahulon12 Why is the textfield selection so slow? |
I looked into this, and it seems like a SwiftUI limitation when there are several text fields being rendered 😭 However, I believe there are ways to get around it, which will require refactoring. I will create a new umbrella issue with all the enhancements/perf issues that are mentioned by everyone in this PR. For the scope of this PR, I hope to focus on functionality and major bugs/code design. |
Fixes #245
Changes Made
Screenshots (if applicable)
Checklist